Merged
Conversation
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .text |
12.58% | 13.00% | +59 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | @unnamed@zTalkBox_cpp@::wait_context::reset_type() |
0.00% | 100.00% | +12 |
| ✅ | @unnamed@zTalkBox_cpp@::parse_tag_pause(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&) |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::reset_tag_pause(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&) |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::trigger_pause(const xtextbox::jot&) |
0.00% | 100.00% | +8 |
| ✅ | @unnamed@zTalkBox_cpp@::start_state_type::stop() |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::start_state_type::update(xScene&, float) |
0.00% | 100.00% | +8 |
| ✅ | @unnamed@zTalkBox_cpp@::next_state_type::stop() |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::stop_state_type::start() |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::stop_state_type::stop() |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::stop_state_type::update(xScene&, float) |
0.00% | 100.00% | +8 |
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .data |
0.00% | 6.58% | +18 |
| 📈 | .text |
12.58% | 13.36% | +111 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | @unnamed@zTalkBox_cpp@::wait_context::reset_type() |
0.00% | 100.00% | +12 |
| ✅ | @unnamed@zTalkBox_cpp@::parse_tag_pause(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&) |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::reset_tag_pause(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&) |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::trigger_pause(const xtextbox::jot&) |
0.00% | 100.00% | +8 |
| ✅ | @unnamed@zTalkBox_cpp@::state_type::state_type(@unnamed@zTalkBox_cpp@::state_enum) |
0.00% | 100.00% | +20 |
| ✅ | ztalkbox::load(xBase&, xDynAsset&, unsigned long) |
0.00% | 100.00% | +32 |
| ✅ | @unnamed@zTalkBox_cpp@::start_state_type::stop() |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::start_state_type::update(xScene&, float) |
0.00% | 100.00% | +8 |
| ✅ | @unnamed@zTalkBox_cpp@::next_state_type::stop() |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::stop_state_type::start() |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::stop_state_type::stop() |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::stop_state_type::update(xScene&, float) |
0.00% | 100.00% | +8 |
JoshSanch
requested changes
Dec 22, 2025
Collaborator
JoshSanch
left a comment
JoshSanch
left a comment
There was a problem hiding this comment.
Nice work :)
Just some clean-up feedback - we have a types.h file which contains custom type definitions for primitive C/C++ types like unsigned char and signed long, etc. Please go through all of the functions and variables here and replace the primitive types with the shorter names from the types.h file. We use those so that it's easy to modify the types for different platforms as needed.
Thanks for contributing!
src/SB/Game/zTalkBox.h
Outdated
| struct start_state_type | ||
| { | ||
| void stop(); | ||
| signed char update(xScene&, float); |
Collaborator
There was a problem hiding this comment.
Although these arguments aren't used and thus don't need to have parameter names for referencing inside the function, for these update functions I would like us to explicitly include parameter names, as they are the most likely to be updated by modders in the future and we've already seen what these arguments are named even if they were stripped from the DWARF data.
Please update the signature to this:
Suggested change
| signed char update(xScene&, float); | |
| S8 update(xScene& scn, F32 dt); |
…o used code formmatting tool
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .data |
0.00% | 6.58% | +18 |
| 📈 | .text |
12.58% | 13.36% | +111 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | @unnamed@zTalkBox_cpp@::wait_context::reset_type() |
0.00% | 100.00% | +12 |
| ✅ | @unnamed@zTalkBox_cpp@::parse_tag_pause(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&) |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::reset_tag_pause(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&) |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::trigger_pause(const xtextbox::jot&) |
0.00% | 100.00% | +8 |
| ✅ | @unnamed@zTalkBox_cpp@::state_type::state_type(@unnamed@zTalkBox_cpp@::state_enum) |
0.00% | 100.00% | +20 |
| ✅ | ztalkbox::load(xBase&, xDynAsset&, unsigned long) |
0.00% | 100.00% | +32 |
| ✅ | @unnamed@zTalkBox_cpp@::start_state_type::stop() |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::start_state_type::update(xScene&, float) |
0.00% | 100.00% | +8 |
| ✅ | @unnamed@zTalkBox_cpp@::next_state_type::stop() |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::stop_state_type::start() |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::stop_state_type::stop() |
0.00% | 100.00% | +4 |
| ✅ | @unnamed@zTalkBox_cpp@::stop_state_type::update(xScene&, float) |
0.00% | 100.00% | +8 |
JoshSanch
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created namespace for parse_tag_pause, reset_tag_pause, and trigger_pause and matched them all
Also matched start_state_type::stop, start_state_type::update, next_state_type::stop, stop_state_type::start, stop_state_type::stop, stop_state_type::update, wait_context::reset_type
Defined the following structs
next_state_type
start_state_type
stop_state_type
Add variable reset_type to wait_context struct